niyue commented on code in PR #38116: URL: https://github.com/apache/arrow/pull/38116#discussion_r1365720948
########## cpp/src/gandiva/cmake/GenerateBitcode.cmake: ########## Review Comment: Thanks @kou. I've rebased to the main branch and resolve the conflict, and I move your change in https://github.com/apache/arrow/pull/36595 into a separated file called `GenerateBitcode.cmake` as I did previously. There are still 2 tasks according to your comments: 1) Move the file into `arrow/cpp/cmake_modules` dir, as I said above, I gave it a try but there is still some issues, could you please help on this part? 2) processing only one file instead of multiple files for the `generate_bitcode` (I can probably give this a try later once the first issue is addressed) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
