fansehep commented on code in PR #4962: URL: https://github.com/apache/arrow-rs/pull/4962#discussion_r1366595597
########## arrow-schema/src/fields.rs: ########## @@ -41,7 +41,7 @@ use std::sync::Arc; #[derive(Clone, Eq, PartialEq, Ord, PartialOrd, Hash)] #[cfg_attr(feature = "serde", derive(serde::Serialize, serde::Deserialize))] #[cfg_attr(feature = "serde", serde(transparent))] -pub struct Fields(Arc<[FieldRef]>); +pub struct Fields(Arc<Vec<FieldRef>>); Review Comment: > I don't think change `[FieldRef]` to `Vec<FieldRef]` is necessary Rust [] is a fixed size vector in compile time, if we want to push a field, should use ‘Vec’? ########## arrow-schema/src/fields.rs: ########## @@ -41,7 +41,7 @@ use std::sync::Arc; #[derive(Clone, Eq, PartialEq, Ord, PartialOrd, Hash)] #[cfg_attr(feature = "serde", derive(serde::Serialize, serde::Deserialize))] #[cfg_attr(feature = "serde", serde(transparent))] -pub struct Fields(Arc<[FieldRef]>); +pub struct Fields(Arc<Vec<FieldRef>>); Review Comment: > I don't think change `[FieldRef]` to `Vec<FieldRef]` is necessary Rust [] is a fixed size vector in compile time, if we want to push a field, should use ‘Vec’? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
