tustvold commented on code in PR #4962:
URL: https://github.com/apache/arrow-rs/pull/4962#discussion_r1368572935
##########
arrow-schema/src/fields.rs:
##########
@@ -83,6 +87,16 @@ impl Fields {
.zip(other.iter())
.all(|(a, b)| Arc::ptr_eq(a, b) || a.contains(b))
}
+
+ pub fn reverse(&mut self) {
+ let new_fields: Vec<FieldRef> = self.iter().rev().map(|f| f.clone() as
FieldRef).collect();
+ self.0 = Arc::new(new_fields);
+ }
+
+ pub fn push(&mut self, field: Field) {
Review Comment:
The proposal in this PR will add an additional pointer indirection to field
access, whilst still requiring atomics for every call to push.
I think the better question is, why not use SchemaBuilder, it will be
faster, less complicated, and avoid having to make changes to Fields?
TLDR is I don't think any of the changes in this PR should be necessary for
#4908
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
