fansehep commented on code in PR #4962: URL: https://github.com/apache/arrow-rs/pull/4962#discussion_r1368564824
########## arrow-schema/src/fields.rs: ########## @@ -83,6 +87,16 @@ impl Fields { .zip(other.iter()) .all(|(a, b)| Arc::ptr_eq(a, b) || a.contains(b)) } + + pub fn reverse(&mut self) { + let new_fields: Vec<FieldRef> = self.iter().rev().map(|f| f.clone() as FieldRef).collect(); + self.0 = Arc::new(new_fields); + } + + pub fn push(&mut self, field: Field) { Review Comment: But `SchemaBuilder` also use `Vec<FieldRef>`, And `Vector` is not expanding too often. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org