viirya commented on code in PR #8794:
URL: https://github.com/apache/arrow-datafusion/pull/8794#discussion_r1445674039
##########
datafusion/physical-plan/src/joins/symmetric_hash_join.rs:
##########
@@ -337,10 +337,6 @@ impl ExecutionPlan for SymmetricHashJoinExec {
Ok(children.iter().any(|u| *u))
}
- fn benefits_from_input_partitioning(&self) -> Vec<bool> {
- vec![false, false]
- }
Review Comment:
I don't see why this sets all false for `SymmetricHashJoinExec`. When the
mode is `StreamJoinPartitionMode::Partitioned`, it requires input distributions
to be `HashPartitioned`s.
I think that we don't need to override default function.
Current test case also proves that.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
