metesynnada commented on code in PR #8794:
URL: https://github.com/apache/arrow-datafusion/pull/8794#discussion_r1445868353
##########
datafusion/physical-plan/src/joins/symmetric_hash_join.rs:
##########
@@ -337,10 +337,6 @@ impl ExecutionPlan for SymmetricHashJoinExec {
Ok(children.iter().any(|u| *u))
}
- fn benefits_from_input_partitioning(&self) -> Vec<bool> {
- vec![false, false]
- }
Review Comment:
It can run without order but may run out of memory. I am planning to add an
optional input requirement for it, thus we can keep the order if it is present
in the plan before optimization. I think you can delete it, then I'll prepare
the PR after this merged.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
