metesynnada commented on code in PR #8794:
URL: https://github.com/apache/arrow-datafusion/pull/8794#discussion_r1445691679
##########
datafusion/physical-plan/src/joins/symmetric_hash_join.rs:
##########
@@ -337,10 +337,6 @@ impl ExecutionPlan for SymmetricHashJoinExec {
Ok(children.iter().any(|u| *u))
}
- fn benefits_from_input_partitioning(&self) -> Vec<bool> {
- vec![false, false]
- }
Review Comment:
Roundbound and hashpartition together remove the input order of the SHJ.
This is why we added this guard, but it was long ago. I will send a fixing PR
for this purpose. If these changes do not affect your tests, can you please
keep it as it is and let me delete it?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
