Omega359 commented on code in PR #9241:
URL: https://github.com/apache/arrow-datafusion/pull/9241#discussion_r1495194042
##########
datafusion/physical-expr/src/array_expressions.rs:
##########
@@ -433,7 +433,7 @@ pub fn array_element(args: &[ArrayRef]) -> Result<ArrayRef>
{
let indexes = as_int64_array(&args[1])?;
general_array_element::<i64>(array, indexes)
}
- _ => exec_err!(
+ _ => not_impl_err!(
Review Comment:
So ... in your opinion what should the error be? All I can think of what I
had previously (exec_err), what @comphead suggested (not_impl_err) or a brand
new error (say invalid_type_err)?
Essentially every single one of the changes I made was for this pattern,
arrays are not special in this regard.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
