comphead commented on code in PR #9241:
URL: https://github.com/apache/arrow-datafusion/pull/9241#discussion_r1500930172
##########
datafusion/physical-expr/src/functions.rs:
##########
@@ -436,7 +437,7 @@ pub fn create_physical_fun(
DataType::LargeUtf8 => {
make_scalar_function_inner(string_expressions::ascii::<i64>)(args)
}
- other => internal_err!("Unsupported data type {other:?} for
function ascii"),
+ other => exec_err!("Unsupported data type {other:?} for function
ascii"),
Review Comment:
In compile it allows you to detect if some match arm missing its
implementation, but if you function supports lets say 2 datatypes of existing
10, not sure how to check that on compile time
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
