alamb commented on code in PR #9241:
URL: https://github.com/apache/arrow-datafusion/pull/9241#discussion_r1497008563
##########
datafusion/physical-expr/src/array_expressions.rs:
##########
@@ -433,7 +433,7 @@ pub fn array_element(args: &[ArrayRef]) -> Result<ArrayRef>
{
let indexes = as_int64_array(&args[1])?;
general_array_element::<i64>(array, indexes)
}
- _ => exec_err!(
+ _ => not_impl_err!(
Review Comment:
I think exec_err is a good choice. THe value of a new structured error is
that some program could react specially to it, but I can't think of a good
reason that the reaction to a "invalid_type_err" would be different than a
exec_err. Thus I don't think a new type is a good idea in this case
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
