viirya commented on code in PR #118:
URL:
https://github.com/apache/arrow-datafusion-comet/pull/118#discussion_r1503883392
##########
spark/src/main/scala/org/apache/spark/sql/comet/operators.scala:
##########
@@ -149,6 +149,9 @@ abstract class CometNativeExec extends CometExec {
/**
* The serialized native query plan, optional. This is only defined when the
current node is the
* "boundary" node between native and Spark.
+ *
+ * Note that derived classes of `CometNativeExec` must have
`serializedPlanOpt` in last product
Review Comment:
Although you can find `serializedPlanOpt` field from all declared fields in
the product, you don't know its order in the constructor (as the order of
`getDeclaredFields` is not guarenteed). We need to have these arguments in the
exact order so we can re-construct the product by calling `makeCopy`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
