advancedxy commented on code in PR #118:
URL:
https://github.com/apache/arrow-datafusion-comet/pull/118#discussion_r1503767343
##########
spark/src/main/scala/org/apache/spark/sql/comet/operators.scala:
##########
@@ -149,6 +149,9 @@ abstract class CometNativeExec extends CometExec {
/**
* The serialized native query plan, optional. This is only defined when the
current node is the
* "boundary" node between native and Spark.
+ *
+ * Note that derived classes of `CometNativeExec` must have
`serializedPlanOpt` in last product
+ * parameter.
*/
def serializedPlanOpt: Option[Array[Byte]]
Review Comment:
I think a maybe better approach would be define a new case class to hold the
serialized plan and then it could be pattern matched such as.
``` scala
case class SerializedPlan(val bytes: Array[Byte])
```
or
``` scala
case class SerializedPlan(val bytesOpt: Option[Array[Byte]])
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
