sunchao commented on code in PR #118:
URL:
https://github.com/apache/arrow-datafusion-comet/pull/118#discussion_r1503677310
##########
spark/src/main/scala/org/apache/spark/sql/comet/operators.scala:
##########
@@ -149,6 +149,9 @@ abstract class CometNativeExec extends CometExec {
/**
* The serialized native query plan, optional. This is only defined when the
current node is the
* "boundary" node between native and Spark.
+ *
+ * Note that derived classes of `BosonNativeExec` must have
`serializedPlanOpt` in last product
Review Comment:
ditto
##########
spark/src/main/scala/org/apache/spark/sql/comet/operators.scala:
##########
@@ -276,13 +279,30 @@ abstract class CometNativeExec extends CometExec {
}
}
+ /**
+ * Maps through product elements except the last one. The last element will
be transformed using
+ * the provided function. This is used to transform `serializedPlanOpt`
parameter in case
+ * classes of Boson native operator where the `serializedPlanOpt` is always
the last produce
Review Comment:
`Boson` -> `Comet`
##########
spark/src/main/scala/org/apache/spark/sql/comet/operators.scala:
##########
@@ -276,13 +279,30 @@ abstract class CometNativeExec extends CometExec {
}
}
+ /**
+ * Maps through product elements except the last one. The last element will
be transformed using
Review Comment:
nit: Instead of "Maps through product elements .." maybe "Copies product
elements to the output array except the last one"?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
