Kimahriman commented on PR #36701: URL: https://github.com/apache/arrow/pull/36701#issuecomment-2125388396
> Looks good! > > And apologies for the _very_ slow follow-up .. > > I have one more request: could you add a simple test for this as well (the large_memory test you edited it good to have, but in most our CI builds those are skipped, so it would be good to have a simple small test as well that is run everywhere). For example there is a `test_array_from_numpy_ascii` and `test_array_from_numpy_unicode`. You could add one case to those tests with specifying the type as the large variant. Parameterized those tests to specify the type and use regular and large types -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
