jorisvandenbossche commented on code in PR #36701:
URL: https://github.com/apache/arrow/pull/36701#discussion_r1609864355
##########
python/pyarrow/src/arrow/python/numpy_to_arrow.cc:
##########
@@ -223,10 +223,16 @@ class NumPyConverter {
Status Visit(const NullType& type) { return
TypeNotImplemented(type.ToString()); }
// NumPy ascii string arrays
+ template <typename T>
+ Status VisitBinary(T* builder);
Status Visit(const BinaryType& type);
+ Status Visit(const LargeBinaryType& type);
// NumPy unicode arrays
+ template <typename T>
+ Status VisitString(T* builder);
Review Comment:
Small nitpick, but could you move those declarations of the helpers into
`protected:` (eg just below `VisitNative` definition)
(I don't think anyone outside of pyarrow is using this, but just to keep it
consistent)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
