Kimahriman commented on code in PR #36701:
URL: https://github.com/apache/arrow/pull/36701#discussion_r1612198830
##########
python/pyarrow/tests/test_array.py:
##########
@@ -2355,32 +2355,33 @@ def test_array_from_numpy_timedelta_incorrect_unit():
pa.array(data)
-def test_array_from_numpy_ascii():
[email protected]('binary_type', [pa.binary(), pa.large_binary()])
Review Comment:
Added a third parameter and just set the expected type in the func
```python
@pytest.mark.parametrize('string_type', [None, pa.utf8(), pa.large_utf8()])
def test_array_from_numpy_unicode(string_type):
# Default when no type is specified should be utf8
expected_type = string_type or pa.utf8()
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]