AlenkaF commented on code in PR #42089:
URL: https://github.com/apache/arrow/pull/42089#discussion_r1634151149
##########
python/benchmarks/common.py:
##########
@@ -347,3 +347,15 @@ def get_type_and_builtins(self, n, type_name):
}
data = factories[kind](n)
return ty, data
+
+
+# RANDS_CHARS and rands are copyright pandas, see
Review Comment:
I am not sure about copying code but to me the current approach feels ok. As
the amount of code is minimal the note about origin of it together with
copyright looks good. Joris will know better though,
##########
python/benchmarks/common.py:
##########
@@ -347,3 +347,15 @@ def get_type_and_builtins(self, n, type_name):
}
data = factories[kind](n)
return ty, data
+
+
+# RANDS_CHARS and rands are copyright pandas, see
Review Comment:
I am not sure about copying code but to me the current approach feels ok. As
the amount of code is minimal the note about origin of it together with
copyright looks good. Joris will know better though.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
