amoeba commented on code in PR #42089:
URL: https://github.com/apache/arrow/pull/42089#discussion_r1633896141
##########
python/benchmarks/common.py:
##########
@@ -347,3 +347,15 @@ def get_type_and_builtins(self, n, type_name):
}
data = factories[kind](n)
return ty, data
+
+
+# RANDS_CHARS and rands are copyright pandas, see
Review Comment:
I'm not sure this is the best or even a correct way of copying in this code
from pandas. I think my preference would be to create a new file in this same
directory called `pandas.py`, include the Pandas BSD license text instead of
the APL-2 text, and copy all of this code in. @jorisvandenbossche @AlenkaF do
either of you know if we need to do this one way or another?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
