jorisvandenbossche commented on code in PR #42089:
URL: https://github.com/apache/arrow/pull/42089#discussion_r1634315768
##########
python/benchmarks/common.py:
##########
@@ -347,3 +347,15 @@ def get_type_and_builtins(self, n, type_name):
}
data = factories[kind](n)
return ty, data
+
+
+# RANDS_CHARS and rands are copyright pandas, see
Review Comment:
I don't think we necessarily have to copy the exact code from pandas (and
deal with the licensing stuff), instead we can write something similar from
scratch?
If you look in `pyarrow/tests/util.py`, I think we have already something
more or less identical
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
