alamb commented on PR #6031: URL: https://github.com/apache/arrow-rs/pull/6031#issuecomment-2218672188
> (I think we should do something to prevent future similar mistakes, but I don't know how). One thing we could do is to remove the explclt `From` impls for `Buffer` that copy data Specifically, remove https://github.com/XiangpengHao/arrow-rs/blob/view-buffer/arrow-buffer/src/buffer/immutable.rs#L361-L370 and make it a function `like `Buffer::from_slice` with an explanation that it copies data -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
