alamb commented on PR #6031: URL: https://github.com/apache/arrow-rs/pull/6031#issuecomment-2220145129
> > What should we do? > > > I don't know, I'm not sure if we want to merge that special make_view, as it is very unintuitive. I'll keep a local copy of this make_view and think about it in the background, maybe I'll have a better idea in a month. > > I think we can justify non intuitive code with sufficient performance gains (justified by benchmarks) and sufficient comments to > Filed https://github.com/apache/arrow-rs/issues/6034 to track this issue -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
