alamb commented on code in PR #6031:
URL: https://github.com/apache/arrow-rs/pull/6031#discussion_r1671360900
##########
parquet/src/arrow/array_reader/byte_view_array.rs:
##########
@@ -316,7 +315,8 @@ impl ByteViewArrayDecoderPlain {
}
pub fn read(&mut self, output: &mut ViewBuffer, len: usize) ->
Result<usize> {
- let block_id = output.append_block(self.buf.clone().into());
+ let buf = arrow_buffer::Buffer::from_bytes(self.buf.clone().into());
Review Comment:
I recommend we split the code into multiple PRs -- this one to improve
performance of the parquet reader and one to make it harder to misuse the API
(which I suspect will be a breaking API change)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
