bkietz commented on code in PR #585:
URL: https://github.com/apache/arrow-nanoarrow/pull/585#discussion_r1718492885
##########
src/nanoarrow/nanoarrow_ipc.h:
##########
@@ -417,6 +417,36 @@ ArrowErrorCode ArrowIpcArrayStreamReaderInit(
struct ArrowArrayStream* out, struct ArrowIpcInputStream* input_stream,
struct ArrowIpcArrayStreamReaderOptions* options);
+/// \brief The magic which appears at the beginning and end of an IPC file,
0-padded.
+#define NANOARROW_IPC_FILE_PADDED_MAGIC "ARROW1\0"
Review Comment:
Well, it's tested that [`sizeof(NANOARROW_IPC_FILE_PADDED_MAGIC) ==
8`](https://github.com/apache/arrow-nanoarrow/pull/585/files#diff-56dcfcba171647e18e8d2b6ce1d7cccd7ff94e44fe53fd87bcba7281a0c11fa7R33).
I can make it internal for now
##########
src/nanoarrow/ipc/writer.c:
##########
@@ -329,3 +362,60 @@ ArrowErrorCode ArrowIpcWriterWriteArrayStream(struct
ArrowIpcWriter* writer,
ArrowArrayViewReset(&array_view);
return NANOARROW_OK;
}
+
+ArrowErrorCode ArrowIpcWriterStartFile(struct ArrowIpcWriter* writer,
+ struct ArrowError* error) {
Review Comment:
Okay
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
