paleolimbot commented on code in PR #585:
URL: https://github.com/apache/arrow-nanoarrow/pull/585#discussion_r1718499425
##########
src/nanoarrow/nanoarrow_ipc.h:
##########
@@ -417,6 +417,36 @@ ArrowErrorCode ArrowIpcArrayStreamReaderInit(
struct ArrowArrayStream* out, struct ArrowIpcInputStream* input_stream,
struct ArrowIpcArrayStreamReaderOptions* options);
+/// \brief The magic which appears at the beginning and end of an IPC file,
0-padded.
+#define NANOARROW_IPC_FILE_PADDED_MAGIC "ARROW1\0"
Review Comment:
Yes, but `strlen(NANOARROW_IPC_FILE_PADDED_MAGIC)` would probably get you 6
(and because it's a string, somebody might do it)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
