bkietz commented on code in PR #585:
URL: https://github.com/apache/arrow-nanoarrow/pull/585#discussion_r1717122588
##########
src/nanoarrow/ipc/encoder.c:
##########
@@ -412,10 +414,12 @@ ArrowErrorCode ArrowIpcEncoderEncodeSchema(struct
ArrowIpcEncoder* encoder,
flatcc_builder_t* builder = &private->builder;
- FLATCC_RETURN_UNLESS_0(Message_start_as_root(builder), error);
- FLATCC_RETURN_UNLESS_0(Message_version_add(builder, ns(MetadataVersion_V5)),
error);
+ if (!private->encoding_footer) {
Review Comment:
How would you like to see them tested? We don't currently have anything
which reads raw Footers, not even a public arrow C++ API which we could borrow.
I could use flatcc to assert that flatcc wrote a valid Footer but that seems
specious
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
