alamb commented on code in PR #6257:
URL: https://github.com/apache/arrow-rs/pull/6257#discussion_r1718841274
##########
parquet/src/file/statistics.rs:
##########
@@ -125,22 +125,35 @@ pub fn from_thrift(
) -> Result<Option<Statistics>> {
Ok(match thrift_stats {
Some(stats) => {
- // Number of nulls recorded, when it is not available, we just
mark it as 0.
- // TODO this should be `None` if there is no information about
NULLS.
- // see https://github.com/apache/arrow-rs/pull/6216/files
- let null_count = stats.null_count.unwrap_or(0);
Review Comment:
the removal of this `unwrap_or` is what changes the semantics while reading
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
