Michael-J-Ward commented on code in PR #6257:
URL: https://github.com/apache/arrow-rs/pull/6257#discussion_r1719985116
##########
parquet/src/arrow/arrow_reader/statistics.rs:
##########
@@ -1195,6 +1197,23 @@ impl<'a> StatisticsConverter<'a> {
self.arrow_field
}
+ /// Set the statistics converter to treat missing null counts as missing
Review Comment:
The default in this PR is `missing_null_counts_as_zero = true`, which
maintains the **old** behavior, right?
If "add this config to maintain old behavior" is acceptable for a breaking
release, then I would expect the default to be the **new** behavior.
IOW, I'd expect what you said on the [parquet mailing
list](https://lists.apache.org/thread/cytmb3n3j72nqmnb90omnvv1w926kth2)
> Applications that use parquet-rs to read parquet_files and interpret the
null_count will need to be changed after the upgrade to explicitly continue
the old behavior of "treat no null_count as 0" which is also documented
now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
