etseidl commented on PR #6257:
URL: https://github.com/apache/arrow-rs/pull/6257#issuecomment-2315831294

   > Unless someone else has time to review this PR and thinks it should go 
into 53.0.0 (#6016) my personal preference would be to merge this PR early in 
the next major release cycle (e.g. 54.0.0) so it gets maximum bake / testing 
time before release
   
   I've looked this PR over several times and haven't found any issues with it. 
The only thing giving me pause is this 
https://github.com/apache/parquet-format/pull/449#discussion_r1730336950
   
   It seems java and cpp ignore the definition levels and write Some(0) 
regardless, so I'm fine with merging this and worrying about micro 
optimizations down the road (in step with the rest of the parquet community).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to