ianmcook commented on a change in pull request #9579:
URL: https://github.com/apache/arrow/pull/9579#discussion_r590419797
##########
File path: r/tools/nixlibs.R
##########
@@ -402,10 +407,11 @@ with_s3_support <- function(env_vars) {
cat("**** S3 support not available for gcc < 4.9; building with
ARROW_S3=OFF\n")
arrow_s3 <- FALSE
} else if (!cmake_find_package("CURL", NULL, env_vars)) {
+ # curl on macos should be installed, so no need to alter this for macos
cat("**** S3 support requires libcurl-devel (rpm) or
libcurl4-openssl-dev (deb); building with ARROW_S3=OFF\n")
arrow_s3 <- FALSE
} else if (!cmake_find_package("OpenSSL", "1.0.2", env_vars)) {
- cat("**** S3 support requires openssl-devel (rpm) or libssl-dev (deb),
version >= 1.0.2; building with ARROW_S3=OFF\n")
+ cat("**** S3 support requires openssl-devel (rpm), libssl-dev (deb),
openssl (brew), version >= 1.0.2; building with ARROW_S3=OFF\n")
Review comment:
Just a small change to make it explicit that one of these things (not
all three) are required and that the version number applies to all of them.
Maybe just this:
```suggestion
cat("**** S3 support requires version >= 1.0.2 of openssl-devel (rpm),
libssl-dev (deb), or openssl (brew); building with ARROW_S3=OFF\n")
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
