paleolimbot commented on code in PR #596: URL: https://github.com/apache/arrow-nanoarrow/pull/596#discussion_r1766033420
########## src/nanoarrow/common/inline_array.h: ########## @@ -467,52 +468,113 @@ static inline ArrowErrorCode ArrowArrayAppendDouble(struct ArrowArray* array, return NANOARROW_OK; } +#define NANOARROW_BINARY_VIEW_INLINE_SIZE 12 +#define NANOARROW_BINARY_VIEW_PREVIEW_SIZE 4 +#define NANOARROW_BINARY_VIEW_BLOCK_SIZE 32 << 10 // 32KB Review Comment: I can add the "build by buffer" stuff in a future PR...the chunking is great to have for appends and ensures you have some test structures to roundtrip! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
