nealrichardson commented on a change in pull request #9674:
URL: https://github.com/apache/arrow/pull/9674#discussion_r594443332
##########
File path: r/tests/testthat/test-dplyr-filter.R
##########
@@ -155,6 +155,59 @@ test_that("filter() with %in%", {
)
})
+test_that("filter() with between()", {
+ expect_dplyr_equal(
+ input %>%
+ filter(between(dbl, 1, 2)) %>%
+ collect(),
+ tbl
+ )
+
+ expect_dplyr_equal(
+ input %>%
+ filter(between(dbl, 0.5, 2)) %>%
+ collect(),
+ tbl
+ )
+
+ expect_dplyr_equal(
Review comment:
You should just use regular `expect_error` here since the arrow version
behaves slightly differently (even when the dplyr version and this version both
error, they give different validation messages). `expect_dplyr_error` asserts
that they give the exact same error message:
https://github.com/apache/arrow/blob/master/r/tests/testthat/helper-expectation.R#L98-L124
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
