nealrichardson commented on a change in pull request #9674:
URL: https://github.com/apache/arrow/pull/9674#discussion_r593532623
##########
File path: r/tests/testthat/test-dplyr-filter.R
##########
@@ -155,6 +155,59 @@ test_that("filter() with %in%", {
)
})
+test_that("filter() with between()", {
+ expect_dplyr_equal(
+ input %>%
+ filter(between(dbl, 1, 2)) %>%
+ collect(),
+ tbl
+ )
+
+ expect_dplyr_equal(
+ input %>%
+ filter(between(dbl, 0.5, 2)) %>%
+ collect(),
+ tbl
+ )
+
+ expect_dplyr_equal(
Review comment:
This is your failing test: because `dplyr` doesn't support the
vector-wise comparison. You can rewrite it without `expect_dplyr_equal`, just
do something like:
```
expect_identical(
tbl %>%
record_batch() %>%
filter(between(dbl, int, dbl2)) %>%
collect(),
tbl %>%
filter(dbl >= int, dbl <= dbl2)
)
```
or something like that.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
