boshek commented on a change in pull request #9674:
URL: https://github.com/apache/arrow/pull/9674#discussion_r593477389
##########
File path: r/tests/testthat/test-dplyr-filter.R
##########
@@ -155,6 +155,15 @@ test_that("filter() with %in%", {
)
})
+test_that("filter() with between()", {
+ expect_dplyr_equal(
+ input %>%
+ filter(between(dbl, 1, 2)) %>%
+ collect(),
+ tbl
+ )
+})
+
Review comment:
I've gone ahead and actually removed all input validation as you
suggested. This gives us a vectorized `between` which I've added some tests
form. IMO the Arrow C++ error messages are fine here. I had to add another dbl
column to the test data to directly test the vectorized operation. Then I just
tried to think of some reasonable use cases and test for those.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
