rluvaton commented on code in PR #7037:
URL: https://github.com/apache/arrow-rs/pull/7037#discussion_r1932326526
##########
arrow-select/src/concat.rs:
##########
@@ -462,6 +478,60 @@ mod tests {
assert_eq!(array_result.as_ref(), &array_expected as &dyn Array);
}
+ #[test]
+ fn test_concat_primitive_list_arrays_slices() {
+ let list1 = vec![
+ Some(vec![Some(-1), Some(-1), Some(2), None, None]),
+ Some(vec![]), // In slice
+ None, // In slice
+ Some(vec![Some(10)]),
+ ];
+ let list1_array = ListArray::from_iter_primitive::<Int64Type, _,
_>(list1.clone());
+ let list1_array = list1_array.slice(1, 2);
Review Comment:
I would add assertion here that the offsets really don't start from 0 to
make sure we actually cover that case
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
