rluvaton commented on code in PR #7037:
URL: https://github.com/apache/arrow-rs/pull/7037#discussion_r1932307233
##########
arrow-select/src/concat.rs:
##########
@@ -156,10 +158,23 @@ fn concat_lists<OffsetSize: OffsetSizeTrait>(
NullBuffer::new(nulls.finish())
});
- let values: Vec<&dyn Array> = lists
- .iter()
- .map(|x| x.values().as_ref())
- .collect::<Vec<_>>();
+ // If any of the lists have slices, we need to slice the values
+ // to ensure that the offsets are correct
+ let mut sliced_values;
Review Comment:
Is slice really expensive? Isn't it zero copy as the actual values
(everything that is using `Buffer`) are behind arc?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
