tustvold commented on code in PR #7037:
URL: https://github.com/apache/arrow-rs/pull/7037#discussion_r1932363719
##########
arrow-select/src/concat.rs:
##########
@@ -156,10 +158,23 @@ fn concat_lists<OffsetSize: OffsetSizeTrait>(
NullBuffer::new(nulls.finish())
});
- let values: Vec<&dyn Array> = lists
- .iter()
- .map(|x| x.values().as_ref())
- .collect::<Vec<_>>();
+ // If any of the lists have slices, we need to slice the values
+ // to ensure that the offsets are correct
+ let mut sliced_values;
Review Comment:
Given this isn't a hot loop, it is invoked once per input array, I suspect
the overheads of slice would likely be irrelevant, but this is also fine
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
