amoeba commented on code in PR #717:
URL: https://github.com/apache/arrow-nanoarrow/pull/717#discussion_r1999367178
##########
r/tests/testthat/test-type.R:
##########
@@ -74,7 +74,18 @@ test_that("timestamp type passes along timezone parameter", {
})
test_that("decimal types pass along precision and scale", {
+ schema <- na_decimal32(12, 10)
Review Comment:
How are you thinking about validation with these helpers? This is
technically an invalid precision but nanoarrow currently passes it through. I
think other na_* also don't validate inputs.
##########
r/NAMESPACE:
##########
@@ -63,7 +63,6 @@ S3method(as_nanoarrow_schema,nanoarrow_schema)
S3method(as_nanoarrow_schema,nanoarrow_vctr)
S3method(c,nanoarrow_vctr)
S3method(convert_array,default)
-S3method(convert_array,double)
Review Comment:
I had initially thought this might be breaking but I see the way you have
things hooked up here `convert_array(..., to = double())` works just like
before. 👍
##########
r/NAMESPACE:
##########
@@ -63,7 +63,6 @@ S3method(as_nanoarrow_schema,nanoarrow_schema)
S3method(as_nanoarrow_schema,nanoarrow_vctr)
S3method(c,nanoarrow_vctr)
S3method(convert_array,default)
-S3method(convert_array,double)
Review Comment:
I had initially thought this might be breaking but I see the way you have
things hooked up here `convert_array(..., to = double())` works just like
before. 👍
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
