paleolimbot commented on code in PR #717:
URL: https://github.com/apache/arrow-nanoarrow/pull/717#discussion_r1999441611
##########
r/tests/testthat/test-type.R:
##########
@@ -74,7 +74,18 @@ test_that("timestamp type passes along timezone parameter", {
})
test_that("decimal types pass along precision and scale", {
+ schema <- na_decimal32(12, 10)
Review Comment:
That's a great point. The validation happens in C
(`ArrowSchemaSetTypeDecimal()`) and now is a good as a time as any to fix it!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
