paleolimbot commented on code in PR #717: URL: https://github.com/apache/arrow-nanoarrow/pull/717#discussion_r1999446528
########## r/NAMESPACE: ########## @@ -63,7 +63,6 @@ S3method(as_nanoarrow_schema,nanoarrow_schema) S3method(as_nanoarrow_schema,nanoarrow_vctr) S3method(c,nanoarrow_vctr) S3method(convert_array,default) -S3method(convert_array,double) Review Comment: Yes, we have a funny two-pass system to ensure we skip S3 dispatch wherever possible (but we still need it to work so that other packages can implement custom behaviour without strictly taking on a nanoarrow dependency). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
