alamb commented on code in PR #7371:
URL: https://github.com/apache/arrow-rs/pull/7371#discussion_r2033138361
##########
parquet/src/arrow/async_reader/metadata.rs:
##########
@@ -280,7 +290,7 @@ where
#[deprecated(since = "53.1.0", note = "Use ParquetMetaDataReader")]
pub async fn fetch_parquet_metadata<F, Fut>(
fetch: F,
- file_size: usize,
+ file_size: u64,
Review Comment:
I think since this function is deprecated, it would be better to leave it as
usize
##########
parquet/src/arrow/async_reader/store.rs:
##########
@@ -325,7 +320,7 @@ mod tests {
let initial_actions = num_actions.load(Ordering::Relaxed);
let reader = ParquetObjectReader::new(store, meta.location)
- .with_file_size(meta.size.try_into().unwrap())
+ .with_file_size(meta.size)
Review Comment:
a good example of how aligning these APIs makes things easier to understand
##########
parquet/src/arrow/async_reader/mod.rs:
##########
@@ -80,10 +80,10 @@ pub use store::*;
/// [`tokio::fs::File`]: https://docs.rs/tokio/latest/tokio/fs/struct.File.html
pub trait AsyncFileReader: Send {
/// Retrieve the bytes in `range`
- fn get_bytes(&mut self, range: Range<usize>) -> BoxFuture<'_,
Result<Bytes>>;
+ fn get_bytes(&mut self, range: Range<u64>) -> BoxFuture<'_, Result<Bytes>>;
Review Comment:
👍
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
