alamb commented on code in PR #7650:
URL: https://github.com/apache/arrow-rs/pull/7650#discussion_r2143589876


##########
arrow-select/src/coalesce.rs:
##########
@@ -123,8 +123,8 @@ pub struct BatchCoalescer {
     schema: SchemaRef,
     /// output batch size
     batch_size: usize,
-    /// In-progress buffered batches
-    buffer: Vec<RecordBatch>,
+    /// In-progress arrays

Review Comment:
   The main change of this PR is to introduce per-type "InProgressArrays" that 
have specializations for each type of array
   
   This PR adds a specialization for StringViewArray (to remove the need for 
`gc_string_view_batch`)
   
   In follow on PRs (maybe tickets) we can add specialized versions for 
PrimitiveArray, StringArray, etc



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to