Dandandan commented on code in PR #7650:
URL: https://github.com/apache/arrow-rs/pull/7650#discussion_r2143676299
##########
arrow-select/src/coalesce.rs:
##########
@@ -158,14 +164,12 @@ impl BatchCoalescer {
/// Push next batch into the Coalescer
///
/// See [`Self::next_completed_batch()`] to retrieve any completed batches.
- pub fn push_batch(&mut self, batch: RecordBatch) -> Result<(), ArrowError>
{
+ pub fn push_batch(&mut self, mut batch: RecordBatch) -> Result<(),
ArrowError> {
if batch.num_rows() == 0 {
Review Comment:
Maybe consider not trying to coalesce the batch whenever it has more than
1/2 (or some other factor) of rows of `batch_size`?
Probably best to have it configurable, as it depends on the usage if this is
a good idea or not.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
