alamb commented on code in PR #7650:
URL: https://github.com/apache/arrow-rs/pull/7650#discussion_r2143743156
##########
arrow-select/src/coalesce.rs:
##########
@@ -158,14 +164,12 @@ impl BatchCoalescer {
/// Push next batch into the Coalescer
///
/// See [`Self::next_completed_batch()`] to retrieve any completed batches.
- pub fn push_batch(&mut self, batch: RecordBatch) -> Result<(), ArrowError>
{
+ pub fn push_batch(&mut self, mut batch: RecordBatch) -> Result<(),
ArrowError> {
if batch.num_rows() == 0 {
Review Comment:
Thanks -- that is a good idea -- I need to review what, if anything, assumes
perfectly sized target batches...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
