WillAyd commented on PR #46839:
URL: https://github.com/apache/arrow/pull/46839#issuecomment-2984269577
Unfortunately I don't think my prior PR is recoverable - I think it got
borked in an outage, so we maybe need to continue along here @kou @raulcd
I think I've addressed all the feedback. With respect to the AppVeyor
failure, it looks like the previous failures occurred with Visual Studio 2019,
and I've made some macros to handle that accordingly. However, I know see the
following AppVeyor error:
```
RUN ] Substrait.ExecReadRelWithLocalFiles
C:/projects/arrow/cpp/src/arrow/engine/substrait/serde_test.cc(1132): error:
Failed
'_error_or_value131.status()' failed with Invalid: Cannot parse URI:
'file://C:projectsarrowcppsubmodulesparquet-testingdata/byte_stream_split.zstd.parquet'
due to syntax error at character '/' (position 54)
```
In the AppVeyor build we set a variable like:
```
set PARQUET_TEST_DATA=%CD%\cpp\submodules\parquet-testing\data
```
and the failing test does a string replace with that against:
```cpp
"uriFile": "file://[DIRECTORY_PLACEHOLDER]/byte_stream_split.zstd.parquet",
```
So I guess Visual Studio is not happy with the mix of forward/backslashes,
although I'm still stumped as to why the changes in this PR would bring that to
light
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
