kou commented on code in PR #46839:
URL: https://github.com/apache/arrow/pull/46839#discussion_r2155907861
##########
cpp/src/arrow/compute/CMakeLists.txt:
##########
@@ -48,9 +48,16 @@ if(ARROW_TESTING AND ARROW_COMPUTE)
add_library(arrow_compute_testing OBJECT ${ARROW_COMPUTE_TESTING_SRCS})
# Even though this is still just an object library we still need to "link"
# arrow_compute_core_testing so that is also included correctly
- target_link_libraries(arrow_compute_testing
- PUBLIC $<TARGET_OBJECTS:arrow_compute_core_testing>
- PUBLIC ${ARROW_GTEST_GTEST_MAIN})
+ if(MSVC AND MSVC_VERSION LESS 1930) # gtest linkage needs compat on Visual
Studio 2019
+ target_link_libraries(arrow_compute_testing
+ PUBLIC $<TARGET_OBJECTS:arrow_compute_core_testing>
+ PUBLIC ${ARROW_GTEST_GTEST_MAIN})
+ else()
+ target_link_libraries(arrow_compute_testing
+ PUBLIC $<TARGET_OBJECTS:arrow_compute_core_testing>
+ PUBLIC ${ARROW_GTEST_GTEST})
+ endif()
+
Review Comment:
```suggestion
```
##########
cpp/src/arrow/c/meson.build:
##########
@@ -15,10 +15,16 @@
# specific language governing permissions and limitations
# under the License.
+if needs_compute
+ arrow_c_bridge_deps = [arrow_compute_test_dep]
+else
+ arrow_c_bridge_deps = []
Review Comment:
Do we need `arrow_test_dep` here?
```suggestion
arrow_c_bridge_deps = [arrow_test_dep]
```
##########
cpp/src/arrow/compute/CMakeLists.txt:
##########
@@ -48,9 +48,16 @@ if(ARROW_TESTING AND ARROW_COMPUTE)
add_library(arrow_compute_testing OBJECT ${ARROW_COMPUTE_TESTING_SRCS})
# Even though this is still just an object library we still need to "link"
# arrow_compute_core_testing so that is also included correctly
- target_link_libraries(arrow_compute_testing
- PUBLIC $<TARGET_OBJECTS:arrow_compute_core_testing>
- PUBLIC ${ARROW_GTEST_GTEST_MAIN})
+ if(MSVC AND MSVC_VERSION LESS 1930) # gtest linkage needs compat on Visual
Studio 2019
Review Comment:
Hmm. Is it really related to Visual Studio version?
It seems that this will be happened with newer Visual Studio.
Could you share the build log URL for this change?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
