WillAyd commented on code in PR #46839:
URL: https://github.com/apache/arrow/pull/46839#discussion_r2157395740
##########
cpp/src/arrow/compute/CMakeLists.txt:
##########
@@ -48,9 +48,16 @@ if(ARROW_TESTING AND ARROW_COMPUTE)
add_library(arrow_compute_testing OBJECT ${ARROW_COMPUTE_TESTING_SRCS})
# Even though this is still just an object library we still need to "link"
# arrow_compute_core_testing so that is also included correctly
- target_link_libraries(arrow_compute_testing
- PUBLIC $<TARGET_OBJECTS:arrow_compute_core_testing>
- PUBLIC ${ARROW_GTEST_GTEST_MAIN})
+ if(MSVC AND MSVC_VERSION LESS 1930) # gtest linkage needs compat on Visual
Studio 2019
Review Comment:
OK without the macro the SEH exceptions are gone, so maybe that was a
temporal issue with AppVeyor. However, I still get the error about the invalid
file path without this macro, which you can see in the latest run here:
https://ci.appveyor.com/project/ApacheSoftwareFoundation/arrow/builds/52266070
In the interim, I fixed up the macro (changed `_MSVC_VER` -> `_MSC_VER`) and
it looks like things are all green, so hopefully that works for now
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
