pitrou commented on code in PR #46789:
URL: https://github.com/apache/arrow/pull/46789#discussion_r2161928332
##########
cpp/src/arrow/util/byte_stream_split_internal.h:
##########
@@ -89,23 +102,72 @@ void ByteStreamSplitDecodeSimd128(const uint8_t* data, int
width, int64_t num_va
}
for (int j = 0; j < kNumStreams; ++j) {
xsimd::store_unaligned(
- reinterpret_cast<int8_t*>(out + (i * kNumStreams + j) *
sizeof(simd_batch)),
+ reinterpret_cast<int8_t*>(out + (i * kNumStreams + j) *
simd_batch::size),
stage[kNumStreamsLog2][j]);
}
}
}
+template <int kNumBytes>
Review Comment:
Being able to instantiate an integer type based on templated number of bytes
sounds quite general to me. It is not specific to SIMD.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
