rok commented on code in PR #7818:
URL: https://github.com/apache/arrow-rs/pull/7818#discussion_r2174960827
##########
parquet/src/arrow/arrow_writer/mod.rs:
##########
@@ -789,44 +790,54 @@ impl ArrowRowGroupWriter {
}
}
-struct ArrowRowGroupWriterFactory {
+/// Factory for creating [`ArrowRowGroupWriter`] instances.
+/// This is used by [`ArrowWriter`] to create row group writers, but can be
used
+/// directly for lower level API.
+pub struct ArrowRowGroupWriterFactory {
#[cfg(feature = "encryption")]
file_encryptor: Option<Arc<FileEncryptor>>,
}
impl ArrowRowGroupWriterFactory {
+ /// Creates a new [`ArrowRowGroupWriterFactory`] using provided
[`SerializedFileWriter`].
#[cfg(feature = "encryption")]
- fn new<W: Write + Send>(file_writer: &SerializedFileWriter<W>) -> Self {
+ pub fn new<W: Write + Send>(file_writer: &SerializedFileWriter<W>) -> Self
{
Self {
file_encryptor: file_writer.file_encryptor(),
}
}
#[cfg(not(feature = "encryption"))]
- fn new<W: Write + Send>(_file_writer: &SerializedFileWriter<W>) -> Self {
+ pub fn new<W: Write + Send>(_file_writer: &SerializedFileWriter<W>) ->
Self {
Self {}
}
+ /// Creates a new [`ArrowRowGroupWriter`] for the given parquet schema and
writer properties.
#[cfg(feature = "encryption")]
- fn create_row_group_writer(
+ pub fn create_row_group_writer(
Review Comment:
Done.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
