rok commented on code in PR #7818:
URL: https://github.com/apache/arrow-rs/pull/7818#discussion_r2198388531


##########
parquet/src/arrow/arrow_writer/mod.rs:
##########
@@ -755,7 +755,7 @@ impl ArrowColumnWriter {
 }
 
 /// Encodes [`RecordBatch`] to a parquet row group
-struct ArrowRowGroupWriter {
+pub struct ArrowRowGroupWriter {

Review Comment:
   Thanks for the quick response @alamb ! :)
   Looking at [the 
example](https://docs.rs/parquet/latest/parquet/arrow/arrow_writer/struct.ArrowColumnWriter.html#example-encoding-two-arrow-arrays-in-parallel)
 - we have to pass a single private `FileEncryptor` object (it has random 
state) to all `ArrowColumnWriter`s, `SerializedRowGroupWriter`s and 
`SerializedFileWriter`. Perhaps we could hide everything into `ArrowWriter` 
I'll have to do a quick check. If you have a cleaner idea we'd be most 
interested!



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to