alamb commented on code in PR #7818:
URL: https://github.com/apache/arrow-rs/pull/7818#discussion_r2198312443


##########
parquet/src/arrow/arrow_writer/mod.rs:
##########
@@ -755,7 +755,7 @@ impl ArrowColumnWriter {
 }
 
 /// Encodes [`RecordBatch`] to a parquet row group
-struct ArrowRowGroupWriter {
+pub struct ArrowRowGroupWriter {

Review Comment:
   Is there a reason we can't use the existing low level APIs documented here: 
https://docs.rs/parquet/latest/parquet/arrow/arrow_writer/struct.ArrowColumnWriter.html#example-encoding-two-arrow-arrays-in-parallel
   
   In other words, do we really need to make what has previously been an 
implementation detail part of the public API?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to